Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add export fields to package.json #600

Closed
wants to merge 0 commits into from
Closed

feat: Add export fields to package.json #600

wants to merge 0 commits into from

Conversation

lachlancollins
Copy link
Contributor

What kind of change does this PR introduce?

What is the current behavior?

For @supabase/auth-helpers-sveltekit:
This entrypoint has types at ./dist/index.d.ts but it is not exported from pkg.exports. Consider adding it to pkg.exports["."].types to be compatible with TypeScript's "moduleResolution": "bundler" compiler option.

What is the new behavior?

  • Warnings removed :)
  • The other packages didn't have warnings but I figured I should add exports while I'm at it

@silentworks
Copy link
Contributor

Please make this PR only for the sveltekit package and not the others as this might lead to side effects for the other packages. I'll get it merged in once this change has been made.

@lachlancollins
Copy link
Contributor Author

@silentworks no worries! I accidentally closed this PR trying to merge changes from main - the new PR is #608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants