fix: use std::result::Result instead of Result in handlebar_helper!() macro #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… macro It is often customary to define crate wide Error and Result type. Something like: type Error = ... type Result<T> = std::result::Result<T, Error> If such Result<T> type is in scope when calling the handlebar_helper!() macro, compilation fails as the number of template argument is not the same. This commit modified macro to rely explicitely on std::result::Result<> instead of the whatever Result type is in scope when the macro is invoked.
|
Thank you! |
sunng87
added a commit
that referenced
this pull request
May 10, 2023
fix: use std::result::Result instead of Result in handlebar_helper!() macro
|
Oh that was quick, thank you :-) |
crapStone
added a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jun 12, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [handlebars](https://github.com/sunng87/handlebars-rust) | dependencies | patch | `4.3.6` -> `4.3.7` | --- ### Release Notes <details> <summary>sunng87/handlebars-rust</summary> ### [`v4.3.7`](https://github.com/sunng87/handlebars-rust/releases/tag/v4.3.7) [Compare Source](sunng87/handlebars-rust@v4.3.6...v4.3.7) - \[Fixed] Use fully qualified name of `Result` in `handlebars_helper` macro \[[#​578](sunng87/handlebars-rust#578)] - \[Fixed] Allow single-quote JSON literal \[[#​577](sunng87/handlebars-rust#577)] </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45Ni4yIiwidXBkYXRlZEluVmVyIjoiMzUuOTYuMiIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AifQ==--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Co-authored-by: crapStone <crapstone01@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1894 Reviewed-by: crapStone <crapstone@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is often customary to define a crate wide
ErrorandResulttype. Something like:If such
Result<T>type is in scope when calling thehandlebar_helper!()macro, compilation fails as the number of template argument does not match.This commit modified macro to rely explicitely on
std::result::Result<>instead of the whatever Result type is in scope when the macro is invoked.