Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace isatty with atty #17

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

lewiszlw
Copy link
Collaborator

isatty is deprecated, the author suggests to use atty. And isatty::stdin_isatty method not implemented on windows.
Tested on windows.
image

@sundy-li sundy-li merged commit 143143f into sundy-li:main Mar 20, 2024
3 checks passed
@sundy-li
Copy link
Owner

@lewiszlw

Hi, thanks for the contribution.

There are many features that arrow_cli may lack compared with bendsql.
If you are willing to use and improve arrow_cli, you can take a look at bendsql and port some useful features here.

@lewiszlw
Copy link
Collaborator Author

lewiszlw commented Mar 20, 2024

I tried bendsql. It needs server supporting version function and system table. I just want a simple interactive flight sql client.

@sundy-li
Copy link
Owner

I tried bendsql. It needs server supporting version function and system table. I just want a simple interactive flight sql client.

Yes,I mean that some pure features may be introduced into this crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants