Skip to content

Commit

Permalink
Work around setuptools issue sqlalchemy#1902
Browse files Browse the repository at this point in the history
Added a workaround for a setuptools-related failure that has been observed
as occurring on Windows installations, where setuptools is not correctly
reporting a build error when the MSVC build dependencies are not installed
and therefore not allowing graceful degradation into non C extensions
builds.

Setuptools issue pypa/setuptools#1902

Fixes: sqlalchemy#4967
Change-Id: I5e21e7e78cb6d927b18afce64cacf8643b98354e
  • Loading branch information
zzzeek authored and sumau committed Dec 29, 2019
1 parent 933f4e1 commit 421aa0f
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
9 changes: 9 additions & 0 deletions doc/build/changelog/unreleased_13/4967.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
.. change::
:tags: bug, installation, windows
:tickets: 4967

Added a workaround for a setuptools-related failure that has been observed
as occurring on Windows installations, where setuptools is not correctly
reporting a build error when the MSVC build dependencies are not installed
and therefore not allowing graceful degradation into non C extensions
builds.
3 changes: 2 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@
if sys.platform == "win32":
# 2.6's distutils.msvc9compiler can raise an IOError when failing to
# find the compiler
ext_errors += (IOError,)
# for TypeError, see https://github.com/pypa/setuptools/issues/1902
ext_errors += (IOError, TypeError)


class BuildFailed(Exception):
Expand Down

0 comments on commit 421aa0f

Please sign in to comment.