Rel3.5working

src/EngineMupdf.cpp

@@ -1505,9 +1505,6 @@ EngineMupdf::EngineMupdf() {
 EngineMupdf::~EngineMupdf() {
     EnterCriticalSection(&pagesAccess);
 
-    // TODO: remove this lock and see what happens
-    EnterCriticalSection(ctxAccess);
-
     for (FzPageInfo* pi : pages) {
         DeleteVecMembers(pi->links);
         DeleteVecMembers(pi->autoLinks);
@@ -1541,7 +1538,6 @@ EngineMupdf::~EngineMupdf() {
     DeleteVecMembers(pages);
 
     for (size_t i = 0; i < dimof(mutexes); i++) {
-        LeaveCriticalSection(&mutexes[i]);
         DeleteCriticalSection(&mutexes[i]);
     }
     LeaveCriticalSection(&pagesAccess);

src/ExternalViewers.cpp

@@ -19,6 +19,8 @@
 #include "ExternalViewers.h"
 #include "Commands.h"
 
+#include "utils/Log.h"
+
 struct ExternalViewerInfo {
     const char* name; // shown to the user
     int cmd;
@@ -300,6 +302,7 @@ bool CanViewWithKnownExternalViewer(WindowTab* tab, int cmd) {
     }
     ExternalViewerInfo* ev = FindExternalViewerInfoByCmd(cmd);
     if (!ev || ev->exeFullPath == nullptr) {
+        logfa("CanViewWithKnownExternalViewer cmd: %d, !ev || ev->exeFullPath == nullptr\n", cmd);
         return false;
     }
     // must match file extension
@@ -309,13 +312,16 @@ bool CanViewWithKnownExternalViewer(WindowTab* tab, int cmd) {
         char* ext = path::GetExtTemp(filePath);
         const char* pos = str::FindI(ev->exts, ext);
         if (!pos) {
+            logfa("CanViewWithKnownExternalViewer cmd: %d, !pos\n", cmd);
             return false;
         }
     }
     Kind engineKind = tab->GetEngineType();
     if (engineKind != nullptr) {
         if (ev->engineKind != nullptr) {
             if (ev->engineKind != engineKind) {
+                logfa("CanViewWithKnownExternalViewer cmd: %d, ev->engineKind '%s' != engineKind '%s'\n", cmd,
+                      ev->engineKind, engineKind);
                 return false;
             }
         }
@@ -363,8 +369,10 @@ static TempStr FormatParamsTemp(const char* cmdLine, WindowTab* tab) {
 
 bool ViewWithKnownExternalViewer(WindowTab* tab, int cmd) {
     bool canView = CanViewWithKnownExternalViewer(tab, cmd);
-    ReportIf(!canView); // TODO: with command palette can send un-enforcable command
     if (!canView) {
+        // TODO: with command palette can send un-enforcable command
+        logfa("ViewWithKnownExternalViewer cmd: %d\n", cmd);
+        ReportIf(!canView);
         return false;
     }
     ExternalViewerInfo* ev = FindExternalViewerInfoByCmd(cmd);

src/StressTesting.cpp

@@ -308,7 +308,7 @@ class TestFileProvider {
     virtual ~TestFileProvider() {
     }
     // returns path of the next file to test or nullptr if done (caller needs to free() the result)
-    virtual char* NextFile() = 0;
+    virtual TempStr NextFile() = 0;
     // start the iteration from the beginning
     virtual void Restart() = 0;
     virtual int GetFilesCount() = 0;
@@ -339,11 +339,12 @@ class FilesProvider : public TestFileProvider {
     ~FilesProvider() override {
     }
 
-    char* NextFile() override {
+    TempStr NextFile() override {
         if (provided >= files.size()) {
             return nullptr;
         }
-        return str::Dup(files.at(provided++));
+        TempStr res = files.at(provided++);
+        return res;
     }
 
     void Restart() override {
@@ -364,7 +365,7 @@ class DirFileProvider : public TestFileProvider {
   public:
     DirFileProvider(const char* path, const char* filter);
     ~DirFileProvider() override;
-    char* NextFile() override;
+    TempStr NextFile() override;
     void Restart() override;
     int GetFilesCount() override;
 };
@@ -386,13 +387,13 @@ bool DirFileProvider::OpenDir(const char* dirPath) {
     bool hasFiles = CollectStressTestSupportedFilesFromDirectory(dirPath, fileFilter, filesToOpen);
     filesToOpen.SortNatural();
 
-    AutoFreeStr pattern(str::Format("%s\\*", dirPath));
+    TempStr pattern = str::FormatTemp("%s\\*", dirPath);
     bool hasSubDirs = CollectPathsFromDirectory(pattern, dirsToVisit, true);
 
     return hasFiles || hasSubDirs;
 }
 
-char* DirFileProvider::NextFile() {
+TempStr DirFileProvider::NextFile() {
     if (filesToOpen.size() > 0) {
         return filesToOpen.PopAt(0);
     }
@@ -695,7 +696,7 @@ static void RandomizeViewingState(StressTest* st) {
 
 static bool GoToNextFile(StressTest* st) {
     for (;;) {
-        AutoFreeStr nextFile(st->fileProvider->NextFile());
+        TempStr nextFile = st->fileProvider->NextFile();
         if (nextFile) {
             if (!IsInRange(st->fileRanges, ++st->fileIndex)) {
                 continue;

src/utils/WinUtil.cpp

@@ -2910,3 +2910,8 @@ void AddPathToRecentDocs(const char* path) {
     WCHAR* pathW = ToWstrTemp(path);
     SHAddToRecentDocs(SHARD_PATH, pathW);
 }
+
+int GetGdiObjectsCount() {
+    DWORD n = GetGuiResources(GetCurrentProcess(), GR_GDIOBJECTS);
+    return (int)n;
+}

src/utils/WinUtil.h

@@ -338,3 +338,13 @@ void TbGetRect(HWND hwnd, int buttonId, RECT* rc);
 
 void TreeViewExpandRecursively(HWND hTree, HTREEITEM hItem, uint flag, bool subtree);
 void AddPathToRecentDocs(const char*);
+
+int GetGdiObjectsCount();
+
+struct CheckGdiLeaks {
+    int initialCount = GetGdiObjectsCount();
+    ~CheckGdiLeaks() {
+        int currCount = GetGdiObjectsCount();
+        CrashIf(currCount > initialCount);
+    }
+};

translations/translations.txt

@@ -1,5 +1,5 @@
 AppTranslator: SumatraPDF
-79bc16efa4d3423f883b991ead7ed7b5e5c5cb1b
+30e97d6fd71649751fcbdfff5968eeb9971e7e60
 :%s annotation. Ctrl+click to edit.
 am:%s մեկնաբանություն: Ctrl+քլիք՝ խմբագրելու համար:
 az:Qeyd %s. Düzəliş etmək üçün Ctrl+düyməyə basın.
@@ -1438,6 +1438,7 @@ uk:Виділити
 vn:&Nổi Bật
 :&Keyboard Shortcuts
 br:Atalhos do Teclado
+de:Tasten&kombinationen
 fr:&Raccourcis clavier
 it:&Tasti rapidi
 pl:Skróty &klawiaturowe
@@ -5842,6 +5843,7 @@ vn:Đã dọn lịch sử của %d tập tin, đã xóa hình thu nhỏ.
 am:Պատմության մաքրում...
 az:Tarixçə silinir...
 br:Limpando o histórico...
+by:Ачыстка гісторыі…
 ca:S'està esborrant l'historial...
 cn:正在清除历史记录…
 cy:Yn clirio hanes...
@@ -14204,6 +14206,7 @@ vn:Mở PDF Đã Nhúng
 am:Բացել նոր պատուհանում
 az:Yeni pəncərədə aç
 br:Abrir em Nova Janela
+by:Адкрыць у новым акне
 ca:Obre en una finestra nova
 cn:在新窗口中打开
 cy:Agor Mewn Ffenestr Newydd