Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnec holdings call #57

Merged
merged 1 commit into from
Mar 23, 2023
Merged

remove unnec holdings call #57

merged 1 commit into from
Mar 23, 2023

Conversation

ndushay
Copy link
Contributor

@ndushay ndushay commented Mar 23, 2023

Why was this change made? 🤔

Fixes #53

supersedes PR #56 which deprecates these methods.

How was this change tested? 🤨

⚡ ⚠ If this change has cross service impact, including data writes to shared file systems, run integration tests and/or test in [stage|qa] environment, in addition to specs. ⚡

@ndushay ndushay closed this Mar 23, 2023
@ndushay ndushay deleted the remove-holdings branch March 23, 2023 21:32
@ndushay ndushay restored the remove-holdings branch March 23, 2023 21:32
@ndushay ndushay reopened this Mar 23, 2023
@mjgiarlo mjgiarlo merged commit 80bfba4 into main Mar 23, 2023
@mjgiarlo mjgiarlo deleted the remove-holdings branch March 23, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mark holdings creation deprecated or remove it
2 participants