Include more context in ResourceNotFound exceptions #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to know which job failed and how many retries were performed.
jmartin-sul
approved these changes
Mar 22, 2023
mjgiarlo
commented
Mar 22, 2023
| @@ -65,7 +65,7 @@ client.fetch_hrid(barcode: "12345") | |||
| => "a7927874" | |||
|
|
|||
| # Request a MARC record given an instance hrid | |||
| # returns a hash if found; raises FolioClient::UnexpectedResponse::ResourceNotFound if instance_hrid not found | |||
| # returns a hash if found; raises FolioClient::ResourceNotFound if instance_hrid not found | |||
There was a problem hiding this comment.
We missed this back when we moved the location of the client exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made? 🤔
This makes it easier to know which job failed and how many retries were performed.
How was this change tested? 🤨
CI + QA