Replace standard with plain-old rubo. #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgiarlo
reviewed
Jan 4, 2024
| - standard | ||
| - standard-custom | ||
| - standard-performance | ||
| - rubocop-performance |
There was a problem hiding this comment.
Did you find this require was no longer necessary? https://github.com/rubocop/rubocop-performance#rubocop-configuration-file seems to suggest we want this here but maybe we have some other ✨ wired up.
There was a problem hiding this comment.
My mistake. Fixed.
mjgiarlo
approved these changes
Jan 4, 2024
7d635b9 to
83f30e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #79
Why was this change made? 🤔
standard wasn't.
How was this change tested? 🤨
⚡ ⚠ If this change has cross service impact, including data writes to shared file systems, run integration tests and/or test in [stage|qa] environment, in addition to specs. ⚡