Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 49 #50

Merged
merged 3 commits into from
Jul 19, 2020
Merged

Issue 49 #50

merged 3 commits into from
Jul 19, 2020

Conversation

alldroll
Copy link
Member

@alldroll alldroll commented Jul 19, 2020

Our storage format for NGramVectors (see below) forces us to create an individual roaring.Bitmap object for each parent. It means, if we have 1kk 1-grams, for 2-grams we will have 1kk Bitmap instances, which obviously is not performant as we use the only feature Rank(x uint64).

[]uint64{
    ...
    parentID << 32 | wordID      // New York (Parent | Word)
    ...
}

So, this PR closes #49

@alldroll alldroll merged commit 3e17bfd into master Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experiment with Roaring64 for NGramVector
1 participant