Fix Windows and Linux CI builds #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I can't speak to the mac and windows builds because I'm not setup to do code-signing, but this does resolve the linux issue #101 for me 🎉 |
The latter is not relevant when using ninja as a build tool.
Typo in ctest command
…mages#10004 Missing quote missing a space break out configure flags per os Flags were swapped for mac and windows move comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Linux and Windows broke again.
So I'm on a campaign to make things more conservative, defend against unintentional breakage.
Linux had some big drama over gcc and clang etc, see actions/runner-images#8659 — it seems to work now with the hack removed.
Windows broke because of actions/runner-images#9990 aka Version 20240603.1.1 — everything was green on Version: 20240514.3.0.
All I know is the benchmarks binary breaks in CI and it can't be reproduced locally. See also https://forum.juce.com/t/fr-improve-the-performance-of-building-juceaide-by-forwarding-compiler-launcher-cmake-args/61543/2?u=sudara
Things looked into:
Edit: found the windows issue, it's actions/runner-images#10004