Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: audit fixes #331

Merged
merged 43 commits into from
Feb 8, 2024
Merged

fix: audit fixes #331

merged 43 commits into from
Feb 8, 2024

Conversation

tamirhemo
Copy link
Contributor

@tamirhemo tamirhemo commented Jan 16, 2024 •
edited by ratankaliani
Loading

Kalos audit fixes.

[TODO]: Link to public report.

tamirhemo and others added 26 commits January 16, 2024 12:15
@tamirhemo
compatibility with Curta audit fixes: assertion on positive sqrt and …
c916742 
…column numbers change
@tamirhemo
Merge remote-tracking branch 'origin/main' into tamir/audit_fixes
cb3ab03
@tamirhemo
fix: num_columns in a test
ece413a
@tamirhemo
fix: range checks on EC points and field element
b85a0c7
@tamirhemo
remove comment
27f8aaa
@tamirhemo
added assert num_bits % chunk_bits == 0
454e91d
@tamirhemo
fix Uint reminder check
1b7a2e3
@kevjue @ratankaliani
added comments for generator results that need to be constrained
25696a2
@kevjue @ratankaliani
audit of unconstrainted hints
d1ed75a
@kevjue @ratankaliani
audit of unconstrainted aync hints
bbbd684
@puma314 @ratankaliani
removed hints and migrated to current lte
ce3ef8e
@tamirhemo @ratankaliani
clippy
4b3db19
@tamirhemo @ratankaliani
todos
1230503
@tamirhemo @ratankaliani
keccac
5a3b955
@tamirhemo @ratankaliani
fix read, read_unsafe and add witness to functions
a87b4e8
@tamirhemo @ratankaliani
fix from_vars_unsafe
77a2cfe
@ctian1 @ratankaliani
chore: update addresses (#332)
47ad593
@ratankaliani
feat(succinct-client): add gateways (#333)
8892625
@ratankaliani
refactor(succinct-client): derive (#336)
843e088
@ratankaliani
fix: rm broken optimism gateway (#334)
54e9b32
@ratankaliani
refactor(succinct-client): gateway not found (#337)
be4d598
@ratankaliani
lint
79ba485
@ratankaliani
read_unsafe
2f11714
@ratankaliani
Merge remote-tracking branch 'origin/main' into tamir/audit_fixes
f0e29d6
@ratankaliani
Merge remote-tracking branch 'origin/tamir/audit_fixes' into ratan/ma…
787396d 
…rk-unconstrained-generators
@ratankaliani
fix
66e0036
@ratankaliani ratankaliani mentioned this pull request Jan 28, 2024
Merged
ratankaliani
ratankaliani approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@ratankaliani ratankaliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! approved by allen on 2/5

@ratankaliani ratankaliani merged commit f71437f into main Feb 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ratankaliani ratankaliani ratankaliani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tamirhemo @ratankaliani @kevjue @puma314 @ctian1