Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Fix golangci-lint failure #50

Closed
wants to merge 1 commit into from

Conversation

anshuldata
Copy link
Contributor

@anshuldata anshuldata commented Aug 19, 2024

  • golangci-lint is failing with below error (here)
    The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

  • Based on this thread, this error is seen on ubuntu-latest. Tried using ubuntu-20.04 as suggested in thread but action failed in installation of golangci-lint here

  • Tried macos-latest too but it fails too with some type errors (here) which seems incorrect.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.33%. Comparing base (cbd28cb) to head (e1f49d9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   52.33%   52.33%           
=======================================
  Files          21       21           
  Lines        6011     6011           
=======================================
  Hits         3146     3146           
  Misses       2676     2676           
  Partials      189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anshuldata anshuldata changed the title Fix golangci-lint failure DRAFT: Fix golangci-lint failure Aug 19, 2024
@anshuldata anshuldata marked this pull request as draft August 19, 2024 10:51
@anshuldata
Copy link
Contributor Author

I converted it to draft. I don't have a working solution for it yet

@jacques-n
Copy link
Contributor

was fixed as part of #51

@jacques-n jacques-n closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants