feat: add ValueString() to all literal types #102

EpsilonPrime · 2025-01-09T10:46:03Z

Adds the functionality QueryString() functionality requested in #100 .

codecov · 2025-01-09T10:47:29Z

Codecov Report

Attention: Patch coverage is 51.88679% with 51 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@8c4fdcb). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
types/types.go	0.00%	47 Missing ⚠️
expr/literals.go	92.30%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage        ?   62.94%           
=======================================
  Files           ?       44           
  Lines           ?    10265           
  Branches        ?        0           
=======================================
  Hits            ?     6461           
  Misses          ?     3519           
  Partials        ?      285

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

expr/literals.go

zeroshade

Overall looks great to me, just a couple nit-picks

zeroshade · 2025-01-14T02:26:16Z

expr/literals.go

+		}
+		return fmt.Sprintf("[%s]", strings.Join(items, ", "))
+	}
+	return fmt.Sprintf("%v", t.Value)


Could we add a test that hits this so the codecov warning goes away?

ok, not done. Turns out that map literals go through a different path. I'm not sure how to get it to visit this line.

zeroshade · 2025-01-14T02:27:54Z

types/types.go

+	date := civil.Date{Year: 1970, Month: time.January, Day: 1}
+	date = date.AddDays(int(d))
+	return date.String()


what's the benefit to this over just using time like we were doing before?

Adding days to time.t can be messed up by daylight savings time. Civil date's base type is days so it isn't affected.

EpsilonPrime force-pushed the literal_revamp branch 2 times, most recently from 6a61c57 to 966a5dc Compare January 9, 2025 19:42

EpsilonPrime requested a review from zeroshade January 9, 2025 19:43

zeroshade reviewed Jan 9, 2025

View reviewed changes