Merge pull request #17 from substancelab/fix_builds

Fix builds
substancelab · Jul 30, 2024 · 85463ac · 85463ac
2 parents 2a1e580 + 4edcd25
commit 85463ac
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 11 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -14,16 +14,30 @@ jobs:
     strategy:
       matrix:
         ruby:
-          - '3.0.5'
-          - '3.1.3'
-          - '3.2.0'
+          - '3.0'
+          - '3.1'
+          - '3.2'
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby }}
         bundler-cache: true
-    - name: Run the default task
-      run: bundle exec rake
+    - name: Tests
+      run: bundle exec rake test
+
+  lint:
+    runs-on: ubuntu-latest
+    name: Lint
+
+    steps:
+    - uses: actions/checkout@v4
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        bundler-cache: true
+        ruby-version: '3.2'
+    - name: StandardRB
+      run: bundle exec rake standard
diff --git a/test/input_group/test_checkbox_field.rb b/test/input_group/test_checkbox_field.rb
@@ -27,7 +27,7 @@ class Felt::InputGroup::CheckboxFieldTest < ViewComponent::TestCase
   include Felt::InputGroup::CommonBehavior
 
   def test_defaults_the_value_to_1
-    @model.send("#{@attribute}=", "Something entirely different")
+    @model.send(:"#{@attribute}=", "Something entirely different")
 
     render_component_to_html
 
@@ -54,7 +54,7 @@ def test_accepts_a_specific_unchecked_value
   end
 
   def test_checks_the_checkbox_if_value_is_truthy
-    @model.send("#{@attribute}=", true)
+    @model.send(:"#{@attribute}=", true)
 
     render_component_to_html
 
@@ -63,7 +63,7 @@ def test_checks_the_checkbox_if_value_is_truthy
   end
 
   def test_unchecks_the_checkbox_if_value_is_falsey
-    @model.send("#{@attribute}=", false)
+    @model.send(:"#{@attribute}=", false)
 
     render_component_to_html
 

diff --git a/test/input_group/test_email_field.rb b/test/input_group/test_email_field.rb
@@ -41,7 +41,7 @@ def test_uses_configured_classes_for_wrapping_element
   end
 
   def test_uses_the_value_from_the_object
-    @model.send("#{@attribute}=", "Something entirely different")
+    @model.send(:"#{@attribute}=", "Something entirely different")
 
     render_component_to_html
 

diff --git a/test/input_group/test_text_field.rb b/test/input_group/test_text_field.rb
@@ -27,7 +27,7 @@ class Felt::InputGroup::TextFieldTest < ViewComponent::TestCase
   include Felt::InputGroup::CommonBehavior
 
   def test_uses_the_value_from_the_object
-    @model.send("#{@attribute}=", "Something entirely different")
+    @model.send(:"#{@attribute}=", "Something entirely different")
 
     render_component_to_html