Add ctx param to GetLocalNode #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and use/propagate in the implementations. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
|
🤖 Created branch: z_pr3224/tpantelis/get_local_node_ctx |
skitt
approved these changes
Nov 21, 2024
dfarrell07
approved these changes
Nov 25, 2024
yboaron
approved these changes
Nov 25, 2024
|
🤖 Closed branches: [z_pr3224/tpantelis/get_local_node_ctx] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows it to be cancelled by the user should retries take too long.
Since
GetLocalNodeis called from theInitmethod even handlers, the ctx param was also added to that method to allow propagation from main. Consequently thecontextchecklinter also revealed other code paths where ctx should be propagated.