Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in RouteAgent resource creation on OpenShift #3186

Closed
wants to merge 1 commit into from

Conversation

yboaron
Copy link
Contributor

@yboaron yboaron commented Oct 10, 2024

RouteAgent resources creation failed on OpenShift with [1] error.

[1]
the object provided is unrecognized (must be of type RouteAgent):
Object 'Kind' is missing in
'{"metadata":{"name":"submqe-azure-ks4th-master-1",

RouteAgent resources creation failed on OpenShift with [1] error.

[1]
the object provided is unrecognized (must be of type RouteAgent):
 Object 'Kind' is missing in
'{"metadata":{"name":"submqe-azure-ks4th-master-1",

Signed-off-by: Yossi Boaron <yboaron@redhat.com>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr3186/yboaron/fixRouteAgentCr
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@@ -300,6 +300,9 @@ func (h *controller) syncRouteAgentStatus() {

func (h *controller) generateRouteAgentObject() *submarinerv1.RouteAgent {
return &submarinerv1.RouteAgent{
TypeMeta: metav1.TypeMeta{
Kind: "RouteAgent",
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be needed. We saw this issue before which was addressed by #3166.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, saw this error in oldest version that didn't include #3166 , will close it

@yboaron yboaron closed this Oct 10, 2024
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr3186/yboaron/fixRouteAgentCr]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants