Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump shipyard and address golangci-lint v1.60.3 errors #3142

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Bump shipyard and address golangci-lint v1.60.3 errors #3142

merged 1 commit into from
Aug 28, 2024

Conversation

tpantelis
Copy link
Contributor

Mostly gosec "integer overflow conversion" issues.

Depends on submariner-io/shipyard#1715

@tpantelis tpantelis self-assigned this Aug 27, 2024
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr3142/tpantelis/v1.60.3_linting
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@tpantelis tpantelis mentioned this pull request Aug 27, 2024
Merged
skitt
skitt approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@skitt skitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... but I don’t think the Shipyard bump is necessary.

@tpantelis
Copy link
Contributor Author

... but I don’t think the Shipyard bump is necessary.

It is b/c some shipyard e2e APIs changed due to gosec strictness.

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Aug 28, 2024
@tpantelis
Bump shipyard and address golangci-lint v1.60.3 errors
53cbe7a 
Mostly gosec "integer overflow conversion" issues.

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
@tpantelis tpantelis enabled auto-merge (rebase) August 28, 2024 15:04
@github-actions GitHub Actions
Copy link
Contributor

This PR/issue depends on:

@tpantelis tpantelis merged commit 8bd453c into submariner-io:devel Aug 28, 2024
38 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr3142/tpantelis/v1.60.3_linting]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skitt skitt skitt approved these changes

@dfarrell07 dfarrell07 dfarrell07 approved these changes

@aswinsuryan aswinsuryan Awaiting requested review from aswinsuryan aswinsuryan is a code owner

@maayanf24 maayanf24 Awaiting requested review from maayanf24 maayanf24 is a code owner

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

@vthapar vthapar Awaiting requested review from vthapar vthapar is a code owner

@yboaron yboaron Awaiting requested review from yboaron yboaron is a code owner

Assignees

@tpantelis tpantelis

Labels
ready-to-test When a PR is ready for full E2E testing
Projects
Submariner 0.19
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tpantelis @submariner-bot @dfarrell07 @skitt