Standardize and simplify E2E GHA config #2831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Shipyard, Globalnet GHA config has a dedicated field. There is no need to pass it with extra-toggles. Doing so makes the config in this repo unnecessary different from other repos and harder to maintain. This should not change the matrix of tested combinations. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
In Shipyard, libreswan is the default cable driver. There's no need to explicitly list it here. This allows us to do an all-defaults E2E matrix cell without duplicating the same test with defaults+libreswan. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
|
🤖 Created branch: z_pr2831/dfarrell07/gha_simplify |
|
I think this will have to go with the K8s version change, as we can't have an all-defaults E2E job in the e2e-full workflow as there's an assumption that will be the name of the default E2E job related to both workflows being in the same file so they can both depend on the images step. This results in our current config duplicating a job, the |
|
🤖 Closed branches: [z_pr2831/dfarrell07/gha_simplify] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the E2E-related GHA config easier to maintain and reason about. See commit messages for details.