Fix race when out-of-order RemoteEndpoint events are seen #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is a gateway migration in a remote cluster or if there is any stale endpoint on the Broker associated with the remoteCluster, the events might come in out of order which can create issues for datapath connectivity. The existing code was already having checks to ignore stale endpoint notifications in the kubeproxy and OVN handler. However, similar check was missing in MTU handler and an issue was seen in one of the environments. This PR moves the checks to the event handler framework and removes them from the registered handlers so that the fix will apply to all the handlers. Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
|
🤖 Created branch: z_pr2399/sridhargaddam/fix-out-of-order-events |
dfarrell07
approved these changes
Apr 6, 2023
This was referenced Apr 6, 2023
skitt
approved these changes
Apr 6, 2023
tpantelis
approved these changes
Apr 6, 2023
|
🤖 Closed branches: [z_pr2399/sridhargaddam/fix-out-of-order-events] |
Jaanki
added a commit
to Jaanki/submariner
that referenced
this pull request
Apr 17, 2023
…2399-origin-release-0.15
Jaanki
added a commit
to Jaanki/submariner
that referenced
this pull request
Apr 17, 2023
…2399-origin-release-0.15
This was referenced Apr 18, 2023
sridhargaddam
added a commit
to sridhargaddam/submariner
that referenced
this pull request
Apr 26, 2023
Related to: submariner-io#2399 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
sridhargaddam
added a commit
to sridhargaddam/submariner
that referenced
this pull request
Apr 26, 2023
Related to: submariner-io#2399 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
tpantelis
pushed a commit
that referenced
this pull request
Apr 26, 2023
Related to: #2399 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
sridhargaddam
added a commit
to sridhargaddam/submariner
that referenced
this pull request
Apr 27, 2023
Related to: submariner-io#2399 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
sridhargaddam
added a commit
to sridhargaddam/submariner
that referenced
this pull request
Apr 27, 2023
Related to: submariner-io#2399 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
sridhargaddam
added a commit
to sridhargaddam/submariner
that referenced
this pull request
Apr 27, 2023
Related to: submariner-io#2399 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt
pushed a commit
that referenced
this pull request
Apr 27, 2023
Related to: #2399 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt
pushed a commit
that referenced
this pull request
Apr 27, 2023
Related to: #2399 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt
pushed a commit
that referenced
this pull request
Apr 27, 2023
Related to: #2399 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
sridhargaddam
added a commit
to sridhargaddam/submariner
that referenced
this pull request
Jun 5, 2023
When there is a gateway migration in a remote cluster or if there is any stale endpoint on the Broker associated with the remoteCluster, the events might come in out of order which can create issues for datapath connectivity. This PR includes the necessary checks in Globalnet pod to ignore any stale events. Related to: submariner-io#2399 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
tpantelis
pushed a commit
that referenced
this pull request
Jun 5, 2023
When there is a gateway migration in a remote cluster or if there is any stale endpoint on the Broker associated with the remoteCluster, the events might come in out of order which can create issues for datapath connectivity. This PR includes the necessary checks in Globalnet pod to ignore any stale events. Related to: #2399 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
sridhargaddam
added a commit
to sridhargaddam/submariner
that referenced
this pull request
Jun 5, 2023
When there is a gateway migration in a remote cluster or if there is any stale endpoint on the Broker associated with the remoteCluster, the events might come in out of order which can create issues for datapath connectivity. This PR includes the necessary checks in Globalnet pod to ignore any stale events. Related to: submariner-io#2399 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
sridhargaddam
added a commit
to sridhargaddam/submariner
that referenced
this pull request
Jun 5, 2023
When there is a gateway migration in a remote cluster or if there is any stale endpoint on the Broker associated with the remoteCluster, the events might come in out of order which can create issues for datapath connectivity. This PR includes the necessary checks in Globalnet pod to ignore any stale events. Related to: submariner-io#2399 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
tpantelis
pushed a commit
that referenced
this pull request
Jun 5, 2023
When there is a gateway migration in a remote cluster or if there is any stale endpoint on the Broker associated with the remoteCluster, the events might come in out of order which can create issues for datapath connectivity. This PR includes the necessary checks in Globalnet pod to ignore any stale events. Related to: #2399 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
tpantelis
pushed a commit
that referenced
this pull request
Jun 5, 2023
When there is a gateway migration in a remote cluster or if there is any stale endpoint on the Broker associated with the remoteCluster, the events might come in out of order which can create issues for datapath connectivity. This PR includes the necessary checks in Globalnet pod to ignore any stale events. Related to: #2399 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
novad03
pushed a commit
to novad03/k8s-submariner
that referenced
this pull request
Nov 25, 2023
Related to: submariner-io/submariner#2399 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
novad03
pushed a commit
to novad03/k8s-submariner
that referenced
this pull request
Nov 25, 2023
When there is a gateway migration in a remote cluster or if there is any stale endpoint on the Broker associated with the remoteCluster, the events might come in out of order which can create issues for datapath connectivity. This PR includes the necessary checks in Globalnet pod to ignore any stale events. Related to: submariner-io/submariner#2399 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a gateway migration in a remote cluster or if there is any stale endpoint on the Broker associated with the remoteCluster, the events might come in out of order which can create issues for datapath connectivity. The existing code was already having checks to ignore stale endpoint notifications in the kubeproxy and OVN handler. However, similar check was missing in MTU handler and an issue was seen in one of the environments. This PR moves the checks to the event handler framework and removes them from the registered handlers so that the fix will apply to all the handlers.