E2E tests not running by default #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR submariner-io#228 modified e2e.sh so it only runs the E2E tests if 'status=keep' and thus the tests no longer run with 'status=onetime', which is the default via 'make ci e2e' as documented. Therefore modified e2e.sh to also check for 'status=onetime'. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
|
This change is |
Jaanki
approved these changes
Dec 4, 2019
mkolesnik
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #228 modified e2e.sh so
it only runs the E2E tests if 'status=keep' and thus the tests no longer run
with 'status=onetime', which is the default via 'make ci e2e' as documented.
Therefore modified e2e.sh to also check for 'status=onetime'.
Signed-off-by: Tom Pantelis tompantelis@gmail.com