Uncouple ci building from e2e #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b9eb236 to
fea8693
Compare
|
Added build-engine script which was left out of the commit. |
skitt
approved these changes
Oct 9, 2019
skitt
requested changes
Oct 9, 2019
This will avoid the double-build of engine, routeagent and operator, because they are built once for ci, and once again for e2e which was not expected. We start doing what documentation says, make compiles/builds, and e2e just runs e2e with an existing build, README.md says: ``` To build `submariner-engine` and `submariner-route-agent` you can trigger `make`, which will perform a Dapperized build of the components. To run basic e2e tests you can trigger `make e2e` command. ```
fea8693 to
7684f4c
Compare
skitt
approved these changes
Oct 9, 2019
|
CI worked. @tpantelis ^ |
tpantelis
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will avoid the double-build of engine, routeagent and operator,
because they are built once for ci, and once again for e2e which
was not expected.
We start doing what documentation says, make compiles/builds, and e2e
just runs e2e with an existing build, README.md says: