E2E scheduling of pods to GW/NonGW nodes #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8be8dd1 to
d04a4f3
Compare
skitt
previously approved these changes
Sep 11, 2019
mangelajo
added a commit
to mangelajo/submariner
that referenced
this pull request
Sep 12, 2019
The concept of TestPodConfig and TestPod is defined, letting us create testing pods from a single interface, and automating the creation of UUID data to exchange. As late modifications has shown that the number of parameters keeps growing having a single fixture to create test pods will make easier to write and read E2E tests. Depends-On: submariner-io#148
mpeterson
previously approved these changes
Sep 12, 2019
8dee790 to
9585d71
Compare
|
@sridhargaddam @mpeterson I posted a second commit with your requested changes, please re-review. |
sridhargaddam
requested changes
Sep 16, 2019
|
The order does not matter , all tests execute in random order always.
Enviado desde mi iPhone
… El 16 sept 2019, a las 20:18, Sridhar Gaddam ***@***.***> escribió:
@sridhargaddam requested changes on this pull request.
In test/e2e/dataplane/tcp_pod_to_service.go:
> @@ -15,8 +15,8 @@ var _ = Describe("[dataplane] Basic Pod to Service tests across clusters without
testPod2ServiceTCP(f, framework.NonGatewayNode, framework.NonGatewayNode)
})
- It("Should be able to perform a Pod to Service TCP connection and exchange data between different clusters NonGW to GW", func() {
- testPod2ServiceTCP(f, framework.NonGatewayNode, framework.GatewayNode)
+ It("Should be able to perform a Pod to Service TCP connection and exchange data between different clusters GW to GW", func() {
Thanks for addressing the other comments.
Lets validate GW to GW use-case before nonGW to nonGW (i.e., move this to line before 14).
If GW to GW fails, then the second use-case is bound to fail.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I see, thanks for clarifying. LGTM. Enviado desde mi iPhone
|
sridhargaddam
previously approved these changes
Sep 17, 2019
tpantelis
reviewed
Sep 17, 2019
1997b56
97b7af6 to
1997b56
Compare
|
I had to fix conflicts with the SRC IP preservation changes. Excuse the repetition which I'm handling in PR#149 in a different way (by making the framework a bit smarter and cleaner).. automating some of the repetitive tasks. |
Before this patch, E2E didn't have any control of where pods landed, this made the testing of different scenarios random. With this patch we ensure the testing of the datapath when traffic needs to transit from a worker node to a gateway node. Cluster type has been converted to an enumeration as part of this commit.
1997b56 to
af73357
Compare
mangelajo
added a commit
to mangelajo/submariner
that referenced
this pull request
Sep 18, 2019
The concept of TestPodConfig and TestPod is defined, letting us create testing pods from a single interface, and automating the creation of UUID data to exchange. As late modifications has shown that the number of parameters keeps growing having a single fixture to create test pods will make easier to write and read E2E tests. Depends-On: submariner-io#148
tpantelis
added a commit
that referenced
this pull request
Oct 30, 2019
* E2E: Refactor handling of pods The concept of TestPodConfig and TestPod is defined, letting us create testing pods from a single interface, and automating the creation of UUID data to exchange. As late modifications has shown that the number of parameters keeps growing having a single fixture to create test pods will make easier to write and read E2E tests. Depends-On: #148 * Address comments inn #149 - renamed TestPod to NetworkPod - renamed createListenerConnectorPair t0 runAndVerifyNetworkPod2ServicePair - renamed other function names where appropriate Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
novad03
added a commit
to novad03/k8s-submariner
that referenced
this pull request
Nov 25, 2023
* E2E: Refactor handling of pods The concept of TestPodConfig and TestPod is defined, letting us create testing pods from a single interface, and automating the creation of UUID data to exchange. As late modifications has shown that the number of parameters keeps growing having a single fixture to create test pods will make easier to write and read E2E tests. Depends-On: submariner-io/submariner#148 * Address comments inn #149 - renamed TestPod to NetworkPod - renamed createListenerConnectorPair t0 runAndVerifyNetworkPod2ServicePair - renamed other function names where appropriate Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, E2E didn't have any control of where pods
landed, this made the testing of different scenarios random.
With this patch we ensure the testing of the datapath when
traffic needs to transit from a worker node to a gateway node.
Cluster type has been converted to an enumeration as part of this
commit.