E2E test for source IP preservation #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds another E2E test to ensure that source IP address is preserved on connections. Depends-On: submariner-io#140
|
@dimaunx this build is passing: https://travis-ci.com/mangelajo/submariner/builds/126440488#L2213 regardless of the E2E test failure. It seems like we're not checking it, I will send a PR to handle that. |
|
@dimaunx I'm not sure why isn't it failing, we have set -e on the e2e.sh :? |
The sed command was hiding the exit status of go test, making CI pass on E2E failure.
|
@dimaunx I think I got it, included it as another commit of this PR. |
|
@sridhargaddam if you give the approval, then @tpantelis can probably merge if he's ok with the patch. |
sridhargaddam
approved these changes
Sep 16, 2019
tpantelis
approved these changes
Sep 17, 2019
|
Waiting for @skitt to review as well. |
skitt
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds another E2E test to ensure that source IP address is preserved
on connections.
Depends-On: #140