Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: enable Calico IPPools deletecollection in RouteAgent RBAC #2861

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Backport: enable Calico IPPools deletecollection in RouteAgent RBAC #2861

merged 1 commit into from
Oct 31, 2023

Conversation

yboaron
Copy link
Contributor

@yboaron yboaron commented Oct 30, 2023 •
edited by sridhargaddam
Loading

When Submariner is uninstalled the Calico IPPools
are deleted using DeleteCollection command.

Orig PR: #2856

@yboaron
Add support for Calico IPPools deletecollection
043903b 
When Submariner is uninstalled the Calico IPPools
are deleted using DeleteCollection command.

Signed-off-by: Yossi Boaron <yboaron@redhat.com>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2861/yboaron/calico_delcoll
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@yboaron yboaron mentioned this pull request Oct 30, 2023
Closed
@yboaron yboaron changed the title Backport: add support for Calico IPPools deletecollection Backport: enable Calico IPPools deletecollection in RouteAgent RBAC Oct 30, 2023
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Oct 31, 2023
sridhargaddam
sridhargaddam reviewed Oct 31, 2023
View reviewed changes
Copy link
Member

@sridhargaddam sridhargaddam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to link the Original PR in the commit message while backporting.

@sridhargaddam sridhargaddam merged commit 39fd429 into submariner-io:release-0.16 Oct 31, 2023
43 of 44 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2861/yboaron/calico_delcoll]

@dfarrell07 dfarrell07 mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaanki Jaanki Jaanki approved these changes

@sridhargaddam sridhargaddam sridhargaddam approved these changes

@dfarrell07 dfarrell07 dfarrell07 approved these changes

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@skitt skitt Awaiting requested review from skitt skitt is a code owner

@tpantelis tpantelis Awaiting requested review from tpantelis tpantelis is a code owner

Assignees

@yboaron yboaron

Labels
ready-to-test When a PR is ready for full E2E testing
Projects
No open projects
Submariner 0.17
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yboaron @submariner-bot @dfarrell07 @sridhargaddam @Jaanki