-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Helm over Operator job to full E2E #1409
Conversation
As we move to better support Helm over Operator deployments, we need to start adding tests to other repos. For now only add a basic, default-only canary job. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
There are broken tests, commented out for now, that need fixes before this can go in. |
|
||
validate_pod_log_files $subm_ns '-l component=submariner-lighthouse' | ||
validate_pod_log_files kube-system '-l k8s-app=kube-dns' | ||
# FIXME: Broken with Helm | ||
#validate_pod_log_files kube-system '-l k8s-app=kube-dns' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder what's this one about
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from gather. This validates that a file with logs for pod with label "k8s-app=kube-dns"
is generated.
🤖 Created branch: z_pr1409/dfarrell07/add_canary_helm_job2 |
@@ -26,6 +27,7 @@ jobs: | |||
include: | |||
# This is the oldest K8s version we try to support | |||
- k8s_version: '1.17' | |||
- deploytool: 'helm' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add another with globalnet too (as we have seen it to be problematic sometimes)
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
🤖 Closed branches: [z_pr1409/dfarrell07/add_canary_helm_job2] |
As we move to better support Helm over Operator deployments, we need to
start adding tests to other repos. For now only add a basic,
default-only canary job.
Signed-off-by: Daniel Farrell dfarrell@redhat.com