Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helm over Operator job to full E2E #1409

Closed

Conversation

dfarrell07
Copy link
Member

As we move to better support Helm over Operator deployments, we need to
start adding tests to other repos. For now only add a basic,
default-only canary job.

Signed-off-by: Daniel Farrell dfarrell@redhat.com

As we move to better support Helm over Operator deployments, we need to
start adding tests to other repos. For now only add a basic,
default-only canary job.

Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
@dfarrell07 dfarrell07 added this to the 0.10-m3 milestone Jun 9, 2021
@dfarrell07 dfarrell07 self-assigned this Jun 9, 2021
@dfarrell07
Copy link
Member Author

There are broken tests, commented out for now, that need fixes before this can go in.

@dfarrell07
Copy link
Member Author

@vthapar I think you added these networkplugin-syncer tests in be79c3a and service discovery tests in 69fd78e Any tips for getting them passing for Helm?

@dfarrell07 dfarrell07 added the ready-to-test When a PR is ready for full E2E testing label Jun 9, 2021
@mangelajo
Copy link
Contributor

@vthapar I think you added these networkplugin-syncer tests in be79c3a and service discovery tests in 69fd78e Any tips for getting them passing for Helm?

Probably those system accounts are missing in helm, I guess

@mangelajo
Copy link
Contributor

@vthapar I think you added these networkplugin-syncer tests in be79c3a and service discovery tests in 69fd78e Any tips for getting them passing for Helm?

Probably those system accounts are missing in helm, I guess

and if that's the case, first good catch! ;)


validate_pod_log_files $subm_ns '-l component=submariner-lighthouse'
validate_pod_log_files kube-system '-l k8s-app=kube-dns'
# FIXME: Broken with Helm
#validate_pod_log_files kube-system '-l k8s-app=kube-dns'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what's this one about

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes from gather. This validates that a file with logs for pod with label "k8s-app=kube-dns" is generated.

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1409/dfarrell07/add_canary_helm_job2
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@@ -26,6 +27,7 @@ jobs:
include:
# This is the oldest K8s version we try to support
- k8s_version: '1.17'
- deploytool: 'helm'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add another with globalnet too (as we have seen it to be problematic sometimes)

@dfarrell07 dfarrell07 removed this from the 0.10-m3 milestone Jul 20, 2021
@stale
Copy link

stale bot commented Aug 4, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 4, 2021
@stale stale bot closed this Aug 11, 2021
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1409/dfarrell07/add_canary_helm_job2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-test When a PR is ready for full E2E testing wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants