Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract helm-docs generation/testing to Makefile #155

Merged
merged 2 commits into from
Jul 27, 2021

Conversation

dfarrell07
Copy link
Member

Signed-off-by: Daniel Farrell dfarrell@redhat.com

@dfarrell07 dfarrell07 added this to the 0.10-m3 milestone Jul 2, 2021
@dfarrell07 dfarrell07 self-assigned this Jul 2, 2021
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr155/dfarrell07/make-hd2
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

skitt
skitt previously requested changes Jul 5, 2021
Copy link
Member

@skitt skitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The end-user instructions need to be updated ;-).

Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
@dfarrell07 dfarrell07 requested a review from skitt July 9, 2021 12:45
@dfarrell07 dfarrell07 dismissed skitt’s stale review July 20, 2021 15:02

Requested fix has been made, Stephen is on PTO and will be away for a while.

@dfarrell07 dfarrell07 enabled auto-merge (rebase) July 23, 2021 18:50
@dfarrell07 dfarrell07 merged commit 2f9156c into submariner-io:devel Jul 27, 2021
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr155/dfarrell07/make-hd2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants