Add chart-testing linting, fix errors #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use copyright notice wording required by CNCF for the maintainers field for both Chart.yaml files. Also fix an indentation error in one Chart.yaml file. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
This field is required by standard chart schemas. It should be v2 for Charts that support Helm v3, as we do. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
The colon in these field names isn't allowed by K8s, and fails ct linting. Use the new names from submariner-operator, which have already been renamed to fix this. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Fixes: submariner-io#68 Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
33 tasks
tpantelis
approved these changes
Jun 11, 2021
|
There's a lot of flakiness showing up in the Flake Finder here and in the submariner-operator repo. I think these failures are the same, not something new caused by this PR. https://github.com/submariner-io/submariner-operator/actions?query=workflow%3A%22Flake+Finder%22 |
SteveMattar
approved these changes
Jun 20, 2021
nyechiel
approved these changes
Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details.