Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable goheader on pkg/join/options.go #1282

Closed

Conversation

skitt
Copy link
Member

@skitt skitt commented Jan 2, 2025

This triggers a false positive in golangci-lint 1.63.2.

This triggers a false positive in golangci-lint 1.63.2.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1282/skitt/golangci-false-positive-options
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@tpantelis
Copy link
Contributor

Hmm... why the false positive just on that one file...

@tpantelis
Copy link
Contributor

For some reason, subctl diagnose is failing when checking the metrics availability but only when globalnet is enabled.

@tpantelis
Copy link
Contributor

tpantelis commented Jan 6, 2025

Included with #1284

@tpantelis tpantelis closed this Jan 6, 2025
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1282/skitt/golangci-false-positive-options]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants