Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit Secret metadata from diff in validate_and_clean_broker_info #1055

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

tpantelis
Copy link
Contributor

@tpantelis tpantelis commented Jan 29, 2024

...to ignore potential updates to resourceVersion and other unimportant fields in the broker.subm file.

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1055/tpantelis/fix_broker_diff
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

...to ignore potential updates to "resourceVersion" and other
unimportant fields.

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Jan 30, 2024
@skitt skitt enabled auto-merge (rebase) January 30, 2024 11:56
@skitt skitt merged commit b19a87a into submariner-io:devel Jan 30, 2024
33 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1055/tpantelis/fix_broker_diff]

@tpantelis tpantelis deleted the fix_broker_diff branch April 4, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants