Add --extracontext arg to subctl verify #1048
Conversation
|
🤖 Created branch: z_pr1048/tpantelis/third_context_for_verify |
cmd/subctl/verify.go
Outdated
| the --enable-disruptive flag is also specified. If running non-interactively (that is with no stdin), | ||
| --enable-disruptive must be specified otherwise disruptive verifications are skipped. | ||
| Long: `This command performs various tests to verify that a Submariner deployment between two clusters, | ||
| specified via the --context and --tocontext args, is functioning properly. Some tests require a third cluster, |
There was a problem hiding this comment.
How about specifying "Some servicediscovery tests require a third cluster" to make it clear that if someone is not using servicediscovery verify they don't need to use this argument.
Or, if service discovery is not enabled for verification give a warn or info message to user that --extracontext will be ignored.
There was a problem hiding this comment.
I was thinking not to make it specific to service discovery in case we ever add other test(s) that need a third cluster.
There was a problem hiding this comment.
Making it genric may be a good idea as there could be use cases later for newer test in connectivity requiring a third cluster.
There was a problem hiding this comment.
I was thinking not to make it specific to service discovery in case we ever add other test(s) that need a third cluster.
We can change the info message when we need it for other suites. As of now it is only service discovery, will help user know that this will apply only to service discovery and other tests don't need this option.
There was a problem hiding this comment.
yeah I agree it would be useful. We can change it later if needed although that kind of thing tends to slip through the cracks.
...to run lighthouse tests that require a third cluster. Added a system test using the new arg that is run when lighthouse is deployed. This requires the cluster settings to specify a third cluster which can be problematic wrt CI env resources. So the System Test globalnet and lighthouse options were split into 2 jobs with lighthouse using a separate cluster settings containing the third cluster and only the control-plane node. Fixes submariner-io#276 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
3fe2ef6 to
bb806f3
Compare
|
🤖 Closed branches: [z_pr1048/tpantelis/third_context_for_verify] |
Release notes for submariner-io/subctl#1048 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Release notes for submariner-io/subctl#1048 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Release notes for submariner-io/subctl#1048 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Release notes for submariner-io/subctl#1048 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
...to run lighthouse tests that require a third cluster.
Added a system test using the new arg that is run when lighthouse is deployed. This requires the cluster settings to specify a third cluster which can be problematic wrt CI env resources. So the System Test globalnet and lighthouse options were split into 2 jobs with lighthouse using a separate cluster settings containing the third cluster and only the control-plane node.
Fixes #276