clusters.sh: handle empty k8s_version #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the Kubernetes version flag is specified in the arguments, but with an empty value, shflags doesn't set the default for us. We need to handle this case explicitly before looking up the value in the associative array. Fixes: submariner-io#578 Signed-off-by: Stephen Kitt <skitt@redhat.com>
mangelajo
approved these changes
Jun 9, 2021
dfarrell07
approved these changes
Jun 9, 2021
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Kubernetes version flag is specified in the arguments, but with
an empty value, shflags doesn't set the default for us. We need to
handle this case explicitly before looking up the value in the
associative array.
Fixes: #578
Signed-off-by: Stephen Kitt skitt@redhat.com