Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Helm Charts in release process #87

Closed
Tracked by #138
dfarrell07 opened this issue Jan 27, 2021 · 14 comments
Closed
Tracked by #138

Include Helm Charts in release process #87

dfarrell07 opened this issue Jan 27, 2021 · 14 comments

Comments

@dfarrell07
Copy link
Member

There's currently no mention of Helm in the releases repo or the release process docs.

[~/go/src/github.com/submariner-io/releases]$ grep -riI helm
[~/go/src/github.com/submariner-io/releases]$ 
[~/go/src/github.com/submariner-io/submariner-website/src/content/development/release-process]$ grep -riI helm
[~/go/src/github.com/submariner-io/submariner-website/src/content/development/release-process]$

We should connect the Helm Charts release automation with the automation here, and document the process on the website.

@dfarrell07 dfarrell07 added documentation Improvements or additions to documentation automation labels Jan 27, 2021
@stale
Copy link

stale bot commented Mar 28, 2021

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 28, 2021
@skitt
Copy link
Member

skitt commented Mar 29, 2021

This is still relevant.

@stale stale bot removed the wontfix This will not be worked on label Mar 29, 2021
@dfarrell07
Copy link
Member Author

@dfarrell07
Copy link
Member Author

Maybe this is something we should prioritize for 0.9 @mkolesnik @mangelajo @tpantelis @skitt @nyechiel? It seems to me like we should have this part of the release hammered out before we consider Submariner supportable.

@tpantelis
Copy link
Contributor

A user pointed out that we're still pinning to Submariner 0.7.0 in all submariner-operator chart versions, including the 0.8.1 and 0.9.0-m2 releases and the current devel.

https://github.com/submariner-io/submariner-charts/blob/v0.8.1/submariner-operator/values.yaml#L14

https://github.com/submariner-io/submariner-charts/blob/v0.9.0-m2/submariner-operator/values.yaml#L37

https://github.com/submariner-io/submariner-charts/blob/devel/submariner-operator/values.yaml#L37

I noticed that too when I fixed the release job. I was going to raise the topic but then slipped my mind ☹️

@mkolesnik
Copy link
Contributor

mkolesnik commented Apr 8, 2021 via email

@mkolesnik mkolesnik self-assigned this Apr 20, 2021
@mkolesnik mkolesnik added this to the 0.10-m2 milestone May 6, 2021
@mkolesnik mkolesnik modified the milestones: 0.10-m2, 0.10-m3 Jun 14, 2021
@mkolesnik mkolesnik removed this from the 0.10-m3 milestone Jul 28, 2021
@stale
Copy link

stale bot commented Nov 25, 2021

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 25, 2021
@skitt skitt removed the wontfix This will not be worked on label Nov 25, 2021
@dfarrell07
Copy link
Member Author

dfarrell07 commented Jan 19, 2022

@Jaanki brought this up on a dev call recently, highlighted that we're still not updating the version in submariner-charts. Is this something we want to try to do in 0.12, @mkolesnik? I just noticed it's in backlog/backlog.

(also I might be able to help with this, if this is a "good-first-issue" for the releases project)

@dfarrell07
Copy link
Member Author

I think this is the step we want to automate: submariner-io/submariner-charts#182

@dfarrell07
Copy link
Member Author

Here's another, from a user: submariner-io/submariner-charts#172

@stale
Copy link

stale bot commented Jul 30, 2022

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 30, 2022
@dfarrell07 dfarrell07 removed the wontfix This will not be worked on label Aug 9, 2022
@stale
Copy link

stale bot commented Dec 21, 2022

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 21, 2022
@mkolesnik mkolesnik added confirmed and removed wontfix This will not be worked on labels Dec 21, 2022
@dfarrell07 dfarrell07 removed the documentation Improvements or additions to documentation label Mar 30, 2023
@dfarrell07
Copy link
Member Author

We do this to some extent now, but there's still more to do:

[~/go/src/submariner-io/submariner-charts]$ gi 0.15                                                                                                                                                                                                                                                                                                                                                                                                                                  [devel]
.github/dependabot.yml:25:    target-branch: "release-0.15"
Makefile:21:HELM_DOCS_VERSION=0.15.0
[~/go/src/submariner-io/submariner-charts]$ gi 0.16                                                                                                                                                                                                                                                                                                                                                                                                                                  [devel]
[~/go/src/submariner-io/submariner-charts]$ gi 0.14                                                                                                                                                                                                                                                                                                                                                                                                                                  [devel]
.github/dependabot.yml:20:    target-branch: "release-0.14"
submariner-operator/README.md:38:| operator.image.tag | string | `"0.14.0"` |  |
submariner-operator/README.md:63:| submariner.images.tag | string | `"0.14.0"` |  |
Makefile:20:CHARTS_VERSION=0.14.0

(should all be 0.16 now)

@tpantelis
Copy link
Contributor

This was implemented in 0.16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants