Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm E2E jobs #519

Merged
merged 1 commit into from
May 3, 2021
Merged

Fix helm E2E jobs #519

merged 1 commit into from
May 3, 2021

Conversation

tpantelis
Copy link
Contributor

@tpantelis tpantelis commented May 3, 2021

The shipyard deploy_helm lib now uses the --service_discovery flag so pass it as a DEPLOY_ARGS.

Fixes #504

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr519/tpantelis/fix_helm_e2e

The shipyard deploy_helm lib now uses the --service_discovery flag
so pass it as a DEPLOY_ARGS.

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
@nyechiel nyechiel merged commit d9fab05 into submariner-io:devel May 3, 2021
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr519/tpantelis/fix_helm_e2e]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm jobs broke on last commit
4 participants