Retry ServiceImport check in check_nginx Makefile target #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Created branch: z_pr1446/tpantelis/retry_check_nginx |
skitt
approved these changes
Nov 21, 2023
e647aeb to
6841b41
Compare
aswinsuryan
approved these changes
Nov 21, 2023
...as it takes a little time for the ServiceImport to be created. This has caused sporadic upgrade test failures. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
6841b41 to
e866009
Compare
|
🤖 Closed branches: [z_pr1446/tpantelis/retry_check_nginx] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...as it takes a little time for the
ServiceImportto be created. This has caused sporadic upgrade test failures.