Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E test for service re-creation #1336

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

tpantelis
Copy link
Contributor

@tpantelis tpantelis commented Aug 2, 2023

...to ensure a service is re-discoverable afterwards. For globalnet, this scenario doesn't work without submariner-io/submariner#2637.

Depends on submariner-io/submariner#2637
Fixes #693

...to ensure a service is re-discoverable afterwards.

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1336/tpantelis/svc_recreate_e2e
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Aug 9, 2023
@dfarrell07 dfarrell07 enabled auto-merge (rebase) August 9, 2023 15:50
@dfarrell07
Copy link
Member

submariner-io/submariner#2637 is merged now, I guess this needs to be updated to include that change to get CI passing.

@tpantelis
Copy link
Contributor Author

submariner-io/submariner#2637 is merged now, I guess this needs to be updated to include that change to get CI passing.

There’s no code dependency - the globalnet job should pass once the new image is published

@github-actions github-actions bot removed the dependent label Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

This PR/issue depends on:

@dfarrell07 dfarrell07 merged commit da9acab into submariner-io:devel Aug 9, 2023
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1336/tpantelis/svc_recreate_e2e]

@tpantelis tpantelis deleted the svc_recreate_e2e branch August 30, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServiceImport is not recreated if Service is deleted and recreated
4 participants