Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subctl component name #857

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Add subctl component name #857

merged 1 commit into from
Mar 4, 2024

Conversation

maayanf24
Copy link
Contributor

@maayanf24 maayanf24 commented Feb 21, 2024

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr857/maayanf24/names

Copy link
Member

@skitt skitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain (in the commit message) why this is needed? Do we need to deploy a subctl pod for subctl gather?

@maayanf24
Copy link
Contributor Author

Could you explain (in the commit message) why this is needed? Do we need to deploy a subctl pod for subctl gather?

done

So it can be used to run `subctl gather` inside a pod
to collect data from metrics.
Refer submariner-io/subctl/issues/795

Signed-off-by: Maayan Friedman <maafried@redhat.com>
@skitt skitt merged commit 2c8e6d3 into submariner-io:devel Mar 4, 2024
16 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr857/maayanf24/names]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants