Add CreateAnew function #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf36deb to
4fe9364
Compare
skitt
reviewed
Feb 23, 2021
pkg/util/create_or_update.go
Outdated
| return err | ||
| } | ||
|
|
||
| return retry.OnError(backOff, apierrors.IsAlreadyExists, func() error { |
There was a problem hiding this comment.
Is there any point in retrying if Create() returns an error other than “already exists”?
There was a problem hiding this comment.
OK, for anyone else following along, @tpantelis pointed out to me that the function is only retried if the error is accepted by the function given as the second argument to OnError, i.e. IsAlreadyExists.
There was a problem hiding this comment.
I refactored it to use wait.ExponentialBackoff directly as OnError doesn't really add value.
For use cases where an existing instance needs to first be deleted. Also added unit tests for the new function and the existing CreateOrUpdate function. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
4fe9364 to
6575d3b
Compare
skitt
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For use cases where an existing instance needs to first be deleted.
Also added unit tests for the new function and the existing
CreateOrUpdatefunction.