Add support for CompletionList.itemDefaults #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #2043
we don't need a fallback here,
becasue we have the following code in LSP/plugin/completion.py:
if item.get("insertTextFormat", InsertTextFormat.PlainText) == InsertTextFormat.Snippet:
self.view.run_command("insert_snippet", {"contents": new_text})
predragnikolic
commented
Feb 11, 2023
|
For the spec, see: CompletionList.itemDefaults https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#completionList CompletionItem.textEditText https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#completionItem |
predragnikolic
commented
Feb 11, 2023
rchl
reviewed
Feb 11, 2023
Co-authored-by: Rafał Chłodnicki <rchl2k@gmail.com>
Co-authored-by: Rafał Chłodnicki <rchl2k@gmail.com>
Co-authored-by: Rafał Chłodnicki <rchl2k@gmail.com>
Co-authored-by: Rafał Chłodnicki <rchl2k@gmail.com>
rchl
reviewed
Feb 11, 2023
rchl
reviewed
Feb 11, 2023
Co-authored-by: Rafał Chłodnicki <rchl2k@gmail.com>
Co-authored-by: Rafał Chłodnicki <rchl2k@gmail.com>
rchl
approved these changes
Feb 11, 2023
rchl
approved these changes
Feb 12, 2023
jwortmann
reviewed
Feb 12, 2023
Co-authored-by: jwortmann <jwortmann@outlook.com>
jwortmann
approved these changes
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2043
This PR add support for item defaults, for the following fields:
The additional logic transforms
editRange+textEditText(if present) to a TextEdit. So all of the logic of how we dealed with TextEdits, stayed the same.This can be tested with this PR of LSP-tailwindcss. That PR is not merged yet, but I do plan to merge it soon.