Use new UnitTesting github actions

[rchl]

Not sure about coverage since I don't see an option to pass the token. But then I don't think we actually care about coverage.

@randy3k

[rchl]

Well, coverage works without the token. Token is only needed if we want to upload it and have the app make a comment. Do we want to make that work @rwols ?

[randy3k]

Codecov token is not needed for public repo. With that said, we should have the options to specify it (in case it is a private Sublime Text package).

[rwols]

I guess it's okay to work without coverage. It doesn't work well anyway because the coverage is not computed from code running in the worker thread from what I remember.

[randy3k]

Looks like there is a bug in UnitTesting preventing upload: SublimeText/UnitTesting@4ba3426

[rchl]

The codecov-upload didn't seem to result in codecov comment being added here but we don't want it anyway so just removing it (and the codecov ENV).

[rchl]

I guess it's okay to work without coverage. It doesn't work well anyway because the coverage is not computed from code running in the worker thread from what I remember.

Yeah, the coverage numbers for sessions.py are pretty low:

plugin/core/sessions.py 843 745 12%

so I guess you are right.

We still have the report in the output but won't be using the upload. Thanks @randy3k for fixing anyway.

[randy3k]

coverage.py could only trace high level threads created by threading library but not lower level threads used by ST worker.

[randy3k]

Just pushed a workaround to detect coverage in the worker thread (inspired by nedbat/coveragepy#686).

[rchl]

It doesn't seem like the coverage has improved - https://github.com/sublimelsp/LSP/runs/4197708709?check_suite_focus=true

Assuming that I've tested it properly.
EDIT: I see, there is a new setting for that.

[randy3k]

It doesn't seem like the coverage has improved - sublimelsp/LSP/runs/4197708709?check_suite_focus=true

Assuming that I've tested it properly. EDIT: I see, there is a new setting for that.

Um, it is because I am still not very certain about the workaround. So better to make it off first.

[rchl]

So better to make it off first.

Sure, just checking it out for fun.

[randy3k]

Definitely a coverage increment here.

[rchl]

Now it's better:

plugin/core/sessions.py 843 482 43%

Not sure how accurate it is now but certainly better.

[randy3k]

The codecov report is more readable.

[rchl]

Strange to me that the lines that declare a function or method (def foo(...):) and imports are always not covered.

But still could be useful to track relative changes, of course.

[randy3k]

You have turned off reload_package_on_testing.

The code is loaded by Sublime before coverage starts. We'll need to reload the package to get those lines covered.

[rchl]

I think reloading the package makes things a bit flaky...

[randy3k]

I think reloading the package makes things a bit flaky...

It could be. However, I think the Windows failure is kind of random error.

[rchl]

It could be. However, I think the Windows failure is kind of random error.

but then I've re-run and mac failed

[randy3k]

It could be the new workaround for worker thread. It will definitely make things slower.