Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing random stub in accepted values list #91

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

8ctopus
Copy link
Contributor

@8ctopus 8ctopus commented Oct 2, 2023

2023-10-02_141149

@jfcherng
Copy link
Collaborator

jfcherng commented Oct 2, 2023

I am not sure whether there are more valid values. Could you copy them from https://github.com/bmewburn/vscode-intelephense/blob/d9f9da554e3441cfcc5139f63765f3e60e31acf8/package.json#L169-L355 ? Thanks.

@8ctopus
Copy link
Contributor Author

8ctopus commented Oct 2, 2023

I did so that's how I found the missing one.

@jfcherng jfcherng changed the title Fix missing random stub in accepted values list fix: missing random stub in accepted values list Oct 2, 2023
@jfcherng jfcherng merged commit c1a64ee into sublimelsp:master Oct 2, 2023
@jfcherng
Copy link
Collaborator

jfcherng commented Oct 2, 2023

Thanks.

@jfcherng jfcherng added the bug Something isn't working label Oct 2, 2023
@8ctopus 8ctopus deleted the fix-settings branch October 2, 2023 10:28
@8ctopus
Copy link
Contributor Author

8ctopus commented Oct 2, 2023

You're welcome! Great plugin, I use it all the time as I'm a sublime fan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants