Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GO module support #7

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Added GO module support #7

merged 1 commit into from
Oct 5, 2018

Conversation

fkollmann
Copy link
Contributor

@fkollmann fkollmann commented Oct 4, 2018

GO v1.11 module support

NOTE: It is important to create a new release including this change! See https://github.com/konsorten/go-xmldom/releases/tag/v1.1.2

WORKAROUND for projects using this library: For now, you can add the following line to the go.mod file: replace github.com/subchen/go-xmldom => github.com/konsorten/go-xmldom v1.1.2

@subchen subchen merged commit d5c937e into subchen:master Oct 5, 2018
@fkollmann
Copy link
Contributor Author

@subchen Thanks for the merge! Is it okay for you to create a new v1.1.2 release to enable the GO module support? Without it no specific version can be referenced by dependent projects.

@subchen
Copy link
Owner

subchen commented Oct 5, 2018

Thanks for your contribution, I will create a new release for this issue.

@subchen
Copy link
Owner

subchen commented Oct 8, 2018

1.1.2 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants