-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiline config option values and Paraview vtu default output #996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple lines?! Take my money!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this 💐
It makes especially DEFINITION_DV a lot easier to handle:)
@@ -2834,6 +2834,7 @@ void CConfig::SetConfig_Parsing(char case_filename[MAX_STRING_SIZE]) { | |||
|
|||
int err_count = 0; // How many errors have we found in the config file | |||
int max_err_count = 30; // Maximum number of errors to print before stopping | |||
int line_count = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a short description here
SU2_PY/SU2/io/config.py
Outdated
continue | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a small comment here maybe like "# Unify lines that end with a continuation char '' "
Proposed Changes
This PR just contains two small changes:
\
at the end of the current line. Commented lines and everything after the\
are skipped. That means the following way to specify an option works now:Furthermore, if an error occurs now during the processing of the config file, the line number is also printed in order to quickly identify the location.
OUTPUT_FILES
is not present. I wanted to do that already when I added the XML format in January, but I simply forgot... The old format can be used withPARAVIEW_LEGACY
andSURFACE_PARAVIEW_LEGACY
.Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.