Restart Features for some python scripts #964

ScSteffen · 2020-04-30T14:46:40Z

Proposed Changes

Allows direct flow computations in shape_optimization.py to run from given restart solution for unsteady optimization.
All you have to do is to copy your restart files e.g. restart_flow_00008.dat and restart_flow_00009.dat in the directory of your .cfg and .su2 (mesh) file and set the corresponding options:
RESTART_SOL=YES
RESTART_ITER=10 (in this example).
The shape_optimization.py script will use this direct restart file for each design. This means, the direct computation will be started from iteration 10 and will run up to the final iteration. The adjoint will run from the final iteration, but stop at the iteration of the restart file.
direct_differentiation.py now also accepts restart files in the same manner.
SENSITIVITY is now a default field in VOLUME_OUTPUT, if the computation mode is DISCRETE_ADJOINT.

Related Work

Issue #909

PR Checklist

I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags).
My contribution is commented and consistent with SU2 style.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

…_restart Merge develope into feature_restart

…_restart pull develop into feature_restart, maybe this fixes bug of not found sensitivity

…to feature_restart

economon · 2020-05-08T20:08:10Z

Concerning this error (I am glad you brought it up):

Error in "virtual void CPhysicalGeometry::SetSensitivity(CConfig*)":

Sensitivity x not found in file.
------------------------------ Error Exit -------------------------------

Did you solve this issue? I think that the problem is related to specifying VOLUME_OUTPUT fields different than the default (or at least I have had one other person report this to me). When you put in custom fields, the sensitivities are not also added by automatically.

I think that we should enforce that the sensitivities are always written to the adjoint restart files, like we do with the coords and conservatives for the primal.

ScSteffen · 2020-05-08T21:28:41Z

Hi @economon

Did you solve this issue? I think that the problem is related to specifying VOLUME_OUTPUT fields different than the default (or at least I have had one other person report this to me). When you put in custom fields, the sensitivities are not also added by automatically.

yes I noticed that adding sensitivity in the output solves the issue.
I agree, it makes sense to put SENSITIVITY as a default entry in the case of adjoints to avoid this problem.

ScSteffen · 2020-05-09T07:21:28Z

I have a question regarding the failed test case:
opt_multiobj1surf_py using the config file inv_wedge_ROE_multiobj_1surf.
In this config, is the option RESTART_SOL=YES neccessary? There is no RESTART_ITER specified.
(Setting RESTART_SOL=NO fixes the failed test, however, I don't want to roam in other test cases without asking first ;) )

Edit: Fixed this issue without touching the test case. I got the point of this test case wrong :)...

pcarruscag · 2020-05-09T09:03:28Z

That option has a default value, set somewhere in CConfig.cpp.

…o heavy - removed

…to feature_restart

ScSteffen · 2020-05-11T12:51:45Z

That option has a default value, set somewhere in CConfig.cpp.

I've added this in the last commit. :)

ScSteffen · 2020-05-12T17:55:53Z

I'm wondering, if a test case for unsteady restart shape optimization would be computationally too expensive for the test system.
Please let me know you opinion on that.
Otherwise this request is complete.

Best
Steffen

pcarruscag · 2020-05-12T18:17:48Z

If you add it to the tutorials test suite... and it runs in < 5min, or it covers a few of the commonly untested options, I'd say go for it.

Out of curiosity, do you use the windowing feature to discard a few initial time steps?

Common/src/CConfig.cpp

SU2_PY/SU2/eval/functions.py

ScSteffen · 2020-05-13T06:16:02Z

If you add it to the tutorials test suite... and it runs in < 5min, or it covers a few of the commonly untested options, I'd say go for it.

Ok!

Out of curiosity, do you use the windowing feature to discard a few initial time steps?

No not directly. The idea and motivation was, that I didn't want to wait until the transient phase of the flow field is computed. So I use a precomputed restart file, which serves as a better "inital guess" than freestream values. Then, so the idea, the transient phase is skipped for the first design, and it is at least shortened for other designs. This way, we safe CPU time.

…shape optimization

…to feature_restart

pcarruscag

It seems the test cases still runs in reasonable time so LGTM, give it a few days before merging in case the optimization people have something to say (I have no skin in this game as I don't use it).

pcarruscag · 2020-05-15T08:39:45Z

SU2_CFD/src/output/CAdjElasticityOutput.cpp

@@ -62,6 +62,11 @@ CAdjElasticityOutput::CAdjElasticityOutput(CConfig *config, unsigned short nDim)
    nRequestedVolumeFields = requestedVolumeFields.size();
  }

+  if (find(requestedVolumeFields.begin(), requestedVolumeFields.end(), string("SENSITIVITY")) == requestedVolumeFields.end()) {


👍 I think this way of what happens in the output stays in the output is clearer, even if it requires duplicating a bit of code across the different adjoint output classes.

Alright, thanks for your feedback on this :)

ScSteffen added 5 commits April 17, 2020 14:00

temporal hotfix vorticity issue 2d

993a44f

Merge branch 'develop' of https://github.com/su2code/SU2 into feature…

6195920

…_restart Merge develope into feature_restart

restart files for shape optimization, part 1, not stable

a272741

Merge branch 'develop' of https://github.com/su2code/SU2 into feature…

004fdec

…_restart pull develop into feature_restart, maybe this fixes bug of not found sensitivity

restart for shapeoptimization part 2 not stable

13b9d8e

ScSteffen requested a review from talbring April 30, 2020 14:46

ScSteffen added the enhancement label Apr 30, 2020

ScSteffen self-assigned this Apr 30, 2020

ScSteffen marked this pull request as draft April 30, 2020 14:52

ScSteffen changed the base branch from master to develop April 30, 2020 14:54

pr-triage bot added the PR: draft label Apr 30, 2020

ScSteffen and others added 5 commits May 2, 2020 18:29

restart flow for unsteady shape_optimization part3 working locally

c29f9f6

Merge branch 'develop' into feature_restart

46d9604

Testing whats wrong

224c634

Merge branch 'feature_restart' of https://github.com/ScSteffen/SU2 in…

905972c

…to feature_restart

small fix

98a0855

ScSteffen added 2 commits May 9, 2020 10:03

added test case for optimization restart

11ac915

spelling error

e586cbe

Merge branch 'develop' into feature_restart

bdef341

economon mentioned this pull request May 9, 2020

Expression language for custom output fields #913

Closed

5 tasks

ScSteffen added 2 commits May 11, 2020 14:46

Sensitivity default added for adjoint restart files, opti test case t…

42bd80c

…o heavy - removed

Merge branch 'feature_restart' of https://github.com/ScSteffen/SU2 in…

bdc52c5

…to feature_restart

ScSteffen added 3 commits May 12, 2020 11:35

removed screen output of test case

d4f5937

restart capabilities for directdiff

5f7fe80

error messages if file not found. try to repair broken test cases.

8276531

ScSteffen changed the title ~~Feature restart [WIP]~~ Feature restart. May 12, 2020

pcarruscag marked this pull request as ready for review May 12, 2020 18:12

pr-triage bot added PR: unreviewed and removed PR: draft labels May 12, 2020

pcarruscag reviewed May 12, 2020

View reviewed changes

Common/src/CConfig.cpp Outdated Show resolved Hide resolved

SU2_PY/SU2/eval/functions.py Outdated Show resolved Hide resolved

ScSteffen and others added 3 commits May 13, 2020 08:53

first order time stepping added, test cases added for directdiff and …

ddbea68

…shape optimization

paste error fixed

50d0cbe

Merge branch 'develop' into feature_restart

32006e6

ScSteffen changed the title ~~Feature restart.~~ WIP Feature restart May 13, 2020

pr-triage bot removed the PR: unreviewed label May 13, 2020

ScSteffen and others added 8 commits May 14, 2020 09:26

fixed directdiff test

4f0c3d8

Merge branch 'feature_restart' of https://github.com/ScSteffen/SU2 in…

7caecb3

…to feature_restart

Merge branch 'develop' into feature_restart

658ce2d

further fix test case

1bc184e

Merge branch 'feature_restart' of https://github.com/ScSteffen/SU2 in…

a86b6b8

…to feature_restart

other version of the SENSITIVITY fix

d8f5b73

small changes test case

e8e0216

small change to restart the test framework...

a2b18ab

pcarruscag approved these changes May 15, 2020

View reviewed changes

remove directdiff restart case.

2472231

ScSteffen changed the title ~~WIP Feature restart~~ Restart Features for some python scripts May 15, 2020

pr-triage bot added the PR: unreviewed label May 15, 2020

Merge branch 'develop' into feature_restart

c3d981b

ScSteffen merged commit 8e4338e into su2code:develop May 18, 2020

pr-triage bot added PR: merged and removed PR: unreviewed labels May 18, 2020

ScSteffen mentioned this pull request May 18, 2020

shape_optimization restart for unsteady cases #909

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restart Features for some python scripts #964

Restart Features for some python scripts #964

ScSteffen commented Apr 30, 2020 •

edited

Loading

economon commented May 8, 2020

ScSteffen commented May 8, 2020 •

edited

Loading

ScSteffen commented May 9, 2020 •

edited

Loading

pcarruscag commented May 9, 2020

ScSteffen commented May 11, 2020

ScSteffen commented May 12, 2020

pcarruscag commented May 12, 2020

ScSteffen commented May 13, 2020 •

edited

Loading

pcarruscag left a comment

pcarruscag May 15, 2020

ScSteffen May 15, 2020

Restart Features for some python scripts #964

Restart Features for some python scripts #964

Conversation

ScSteffen commented Apr 30, 2020 • edited Loading

Proposed Changes

Related Work

PR Checklist

economon commented May 8, 2020

Error in "virtual void CPhysicalGeometry::SetSensitivity(CConfig*)":

ScSteffen commented May 8, 2020 • edited Loading

ScSteffen commented May 9, 2020 • edited Loading

pcarruscag commented May 9, 2020

ScSteffen commented May 11, 2020

ScSteffen commented May 12, 2020

pcarruscag commented May 12, 2020

ScSteffen commented May 13, 2020 • edited Loading

pcarruscag left a comment

Choose a reason for hiding this comment

pcarruscag May 15, 2020

Choose a reason for hiding this comment

ScSteffen May 15, 2020

Choose a reason for hiding this comment

ScSteffen commented Apr 30, 2020 •

edited

Loading

ScSteffen commented May 8, 2020 •

edited

Loading

ScSteffen commented May 9, 2020 •

edited

Loading

ScSteffen commented May 13, 2020 •

edited

Loading