fixing for support for SST model in C1Dinterpolation #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auzbaig
referenced
this pull request
Mar 23, 2020
|
@pcarruscag and thanks alot for doing the formatting corrections on my behalf. |
pcarruscag
reviewed
Mar 23, 2020
Comment on lines
149
to
151
| if (nVar_Turb == 1) | ||
| Inlet_Values[nDim+5] = Inlet_Interpolated[5]; | ||
| else if (nVar_Turb == 2) | ||
| if (nVar_Turb == 2) |
There was a problem hiding this comment.
It was not by accident, nVar_Turb cannot be both 1 and 2, only one of those branches executes, if your intention is to execute both branches when nVar_Turb is 2, the code is wrong.
There was a problem hiding this comment.
@pcarruscag Thanks for the correction. I have changed the code, correctly with the else-if.
else if (nVar_Turb == 2){
Inlet_Values[nDim+5] = Inlet_Interpolated[5];
Inlet_Values[nDim+6] = Inlet_Interpolated[6];
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small change to fix support for SST model.
@pcarruscag I think you inadvertently added an else-if during your formatting corrections. I intentionally did not use an else-if as it will support both SA and SST models.
Thanks.