Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discrete adjoint for deforming meshes #833

Merged
merged 135 commits into from
Apr 10, 2020
Merged

Discrete adjoint for deforming meshes #833

merged 135 commits into from
Apr 10, 2020

Conversation

cvencro
Copy link
Contributor

@cvencro cvencro commented Dec 8, 2019 •
edited
Loading

Proposed Changes

This PR introduces surface deformation routines in CMeshSolver and enables discrete adjoint calculations for deforming mesh problems. Gradient verification for a pitching airfoil using a deforming mesh is good compared against rigid motion for the same pitching airfoil:

image

Related Work

Contains PR #919 which cleaned up legacy FSI and deformation methods
Builds on work previously discussed in PR #766
Includes fix for issue #860

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

@pr-triage pr-triage bot added the PR: draft label Dec 8, 2019
@cvencro cvencro changed the title Discrete adjoint for deforming meshes WIP Discrete adjoint for deforming meshes Dec 8, 2019
@cvencro cvencro mentioned this pull request Dec 9, 2019
Closed
@cvencro cvencro mentioned this pull request Feb 5, 2020
Closed
@cvencro cvencro mentioned this pull request Feb 17, 2020
Closed
5 tasks
pcarruscag and others added 11 commits April 6, 2020 12:59
@pcarruscag
fix mpi consistency issues for isoparametric interpolation
af67917
@cvencro
Merge pull request #919 from su2code/grid_deformation_legacy_cleanup
c3fe652 
Grid deformation and FSI legacy cleanup
@pcarruscag
improve "best donor element" search
f41b078
@pcarruscag
handle perfect matches of vertices
2792f0c
@pcarruscag
avoid numerical issues for triangles by solving normal equations
fc59fa2
@pcarruscag
Merge remote-tracking branch 'upstream/develop' into grid_deformation…
86a43cd 
…_legacy_cleanup
@pcarruscag
Merge branch 'grid_deformation_legacy_cleanup' into feature_dyn_defor…
ae4650b 
…m_adjoint
@pcarruscag
improve CMirror to use less memory when interpolation matrix is dense
6df502d
@pcarruscag
minor compiler warning
2983736
@pcarruscag
speedup searched in CMirror by sorting matrix by search keys
bf0d4d3
@pcarruscag
Merge branch 'grid_deformation_legacy_cleanup' into feature_dyn_defor…
fbf40bf 
…m_adjoint
@pcarruscag pcarruscag mentioned this pull request Apr 7, 2020
Closed
5 tasks
pcarruscag
pcarruscag approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Contains the work from #914 and #919.

@pcarruscag pcarruscag mentioned this pull request Apr 10, 2020
Closed
@pcarruscag pcarruscag merged commit 55a70bf into develop Apr 10, 2020
@pcarruscag pcarruscag deleted the feature_dyn_deform_adjoint branch April 10, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcarruscag pcarruscag pcarruscag approved these changes

Assignees
No one assigned
Labels
changelog:feature PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cvencro @pcarruscag