Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure geometry structure #825

Merged
merged 14 commits into from
Dec 2, 2019
Merged

Conversation

pcarruscag
Copy link
Member

Proposed Changes

Split geometry_structure.cpp/hpp in one file per class, strip spaces, replace tabs, move inlines to .hpp, etc.

This depends on #790, the only open PR affected by this is #773, @TobiKattmann I think it should be an easy merge since you only added new code.

Related Work

#583

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.

@pcarruscag
Copy link
Member Author

@talbring @rsanfer I noticed some of the new output files were missing the SU2 header, this PR also addresses that.

Copy link
Member

@talbring talbring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pcarruscag ! Looks good.

@pcarruscag pcarruscag merged commit 7e5e421 into develop Dec 2, 2019
@pcarruscag pcarruscag deleted the restructure_geometry_structure branch December 2, 2019 13:18
@TobiKattmann
Copy link
Contributor

Thanks for the heads up @pcarruscag . merging was no problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants