Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v7.0.0 "Blackbird" #762

Merged
merged 40 commits into from
Nov 29, 2019
Merged

Release v7.0.0 "Blackbird" #762

merged 40 commits into from
Nov 29, 2019

Conversation

talbring
Copy link
Member

@talbring talbring commented Aug 20, 2019

Proposed Changes

This is a preparation for the upcoming release 7 "Blackbird". The schedule is planned like this:

  • 08/27: Pull request opening window ends. PRs with new features opened after this date will not be considered for v7.0.0.
  • 09/01 - 09/29: Testing phase. Only PRs with bugfixes and remaining PRs opened before 08/27 will be merged during that phase.
  • 09/30: Release date.

Note that we will have a stricter policy for new features for this release: Features with no documentation or tutorial(s) will not be advertised. Please also remember to prepare for #724.

If you have any questions, please let me know. Also if you can offer any help with testing/updating documentation.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.

@dep dep bot added the dependent label Aug 22, 2019
@talbring
Copy link
Member Author

The window to open additional PRs is going to end today. You can still open new ones, but they will be merged after the release (except bugfixes).

We have quite a bit of PRs open now. Everybody is encouraged to do reviews! Please take that chance.

@talbring talbring changed the title Release v7.0.0 "Blackbird" WIP Release v7.0.0 "Blackbird" Aug 28, 2019
@talbring
Copy link
Member Author

PR opening window is closed now. Thanks to all the people contributing.

Since we only have a limited amount of time to deal with all the PRs we have to be a bit structured. That means the following:

  • Since we only have a limited amount of concurrent Travis jobs we might manually cancel some jobs in order to give precedence to PRs which have reviews and are likely to be merged once Travis passes. Please check your branch once in a while to restart the job if necessary.

  • If you have comments on a PR that you think should be addressed before merging, please block the merge by requesting changes.

  • Make use of the WIP feature. Especially if you think that you are not able to work on your PR in any ways for a couple of days (including addressing comments). This makes it easier for us to find an order for reviewing/merging.

@jayantmukho
Copy link
Contributor

Since we're trying not to clog Travis, Is there a way to prevent Travis from running the regression tests on every push to a branch that is in the PR process?

@talbring
Copy link
Member Author

talbring commented Aug 29, 2019

@jayantmukho There is no general setting. But you can change the branch in .travis.yml to something else than develop or you add [ci skip] to the commit message. That will prevent travis from running automatically.

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asking for regression tests on discrete adjoint FSI capabilities to be re enabled before the release.

@pr-triage pr-triage bot removed the PR: unreviewed label Oct 4, 2019
@pcarruscag pcarruscag dismissed their stale review October 22, 2019 14:22

problem solved

@talbring talbring changed the title WIP Release v7.0.0 "Blackbird" Release v7.0.0 "Blackbird" Nov 29, 2019
@dep dep bot added the dependent label Nov 29, 2019
@dep dep bot added dependent and removed dependent labels Nov 29, 2019
Copy link
Contributor

@rsanfer rsanfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to fly... 🐣

@talbring talbring merged commit d33823f into develop Nov 29, 2019
@talbring talbring deleted the release_v7.0.0 branch November 29, 2019 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants