Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGNS format for FFD boxes #674

Merged
merged 10 commits into from
May 16, 2019
Merged

CGNS format for FFD boxes #674

merged 10 commits into from
May 16, 2019

Conversation

MicK7
Copy link
Contributor

@MicK7 MicK7 commented Apr 26, 2019

Proposed Changes

  • This PR proposes to add CGNS format as a possible writing format for FFD box

Related Work

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.

@MicK7 MicK7 changed the base branch from master to develop April 26, 2019 09:44
@pcarruscag
Copy link
Member

Hi @MicK7,
Thank you for the feature, it looks ok to me. But cleaning the indentation may cause a lot of merge issues to others, so I will give it time to see if anyone has issues.
Cheers,
Pedro

Throw explicit message when CGNS support is not present
Copy link
Member

@economon economon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Indentation is ok for me, but let's see if anyone else has a concern.

This is a very nice contribution @MicK7 - thanks! Btw, since you clearly have some experience with the CGNS library, we could certainly use help with a few other CGNS-related items. Let me know if you are interested, and I can share more.

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you again for the contribution @MicK7.

@pcarruscag pcarruscag merged commit 3bef190 into su2code:develop May 16, 2019
@MicK7 MicK7 deleted the feature_FFDBox_CGNS branch May 16, 2019 11:27
@talbring talbring changed the title Feature ffd box in CGNS format CGNS format for FFD boxes Nov 8, 2019
@pr-triage pr-triage bot added the PR: merged label Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants