-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CGNS format for FFD boxes #674
Conversation
Hi @MicK7, |
Throw explicit message when CGNS support is not present
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Indentation is ok for me, but let's see if anyone else has a concern.
This is a very nice contribution @MicK7 - thanks! Btw, since you clearly have some experience with the CGNS library, we could certainly use help with a few other CGNS-related items. Let me know if you are interested, and I can share more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you again for the contribution @MicK7.
Proposed Changes
Related Work
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.