Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Update turbo interfaces #2209

Merged
merged 374 commits into from
Sep 4, 2024
Merged

[WIP] Update turbo interfaces #2209

merged 374 commits into from
Sep 4, 2024

Conversation

joshkellyjak
Copy link
Contributor

Proposed Changes

Update to the interface initialisation to enable both mixing plane and sliding interfaces within the same turbomachinery simulation. Addition of mass flow outlet to Giles BC.

Related Work

This issue solves a problem reported by a number of users, when simulating radial turbomachinery cases a second-order accurate solution cannot be achieved in some cases when using mixing plane interfaces. This is due to circumfrential averaging in regions where the flow exhibits large circumfrential nonuniformity and/or interspace gaps between adjacent blade-rows/zones small. This issue has been reported by @LorenzoFabris, in a presentation at the SU2 Conference 2022 "Performance Analysis and Shape Optimization of a Radial Compressor with the Open-Source Software SU2" and by myself.

Mass flow outlet included in the PR as requested by users.

TBC:
-Update APU Turbocharger test case and regression test to include this feature, add diffuser and converge 2nd order.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@joshkellyjak joshkellyjak changed the title Update turbo interfaces [Draft] Update turbo interfaces Feb 13, 2024
@joshkellyjak joshkellyjak changed the title [Draft] Update turbo interfaces [WIP] Update turbo interfaces Feb 13, 2024
@joshkellyjak joshkellyjak self-assigned this Feb 13, 2024
@joshkellyjak joshkellyjak mentioned this pull request Mar 6, 2024
Closed
pcarruscag and others added 23 commits March 15, 2024 18:07
@pcarruscag
Update TestCases/turbomachinery/Aachen_turbine/aachen_3D_MP_restart.cfg
8b039ab
@pcarruscag
Merge pull request su2code#2242 from su2code/tsan_workaround
f817924 
Workaround for ASLR/tsan incompatibility
@EvertBunschoten
Merge branch 'develop' into feature_profiling
82bedbf
@EvertBunschoten
Commit to restart GitHub checks
9cfed5f
@alecappiello
Merge branch 'su2code:develop' into develop
4f32743
@EvertBunschoten
Merge pull request su2code#2243 from su2code/feature_profiling
35231dd 
Added gprof profiling option
@Cristopher-Morales
Merge branch 'develop' into master
afbd80b
@joshkellyjak
Fix in mass flow outlet calculation
b7fe757
@jblueh
Update container image tags.
9c4e37a
@jblueh
Add job for building SU2 with the address sanitizer.
c2a2c57
@jblueh
Fix.
5ff2348
@jblueh
Remove slash.
bc6362f
@jblueh
Address sanitizer builds without python wrapper and unit tests.
3c32cd4
@EvertBunschoten
Merge branch 'develop' of https://github.com/su2code/SU2 into feature…
408c2d1 
…_new_flamelet
@jblueh
Add --asan flag, add with_asan parameter.
acd1a76
@jblueh
Add basic tsan/asan checks to further run_* routines.
c16aab2
@jblueh
Enable address sanitizer execution of SU2_CFD serial regression tests.
c84780e
@jblueh
Add job for address sanitizer tests.
8a79faa
@ShiheJia
Start volume averaging after StartWindowIteration
4a617a1
@jblueh
Avoid reallocation of surface_movement.
3e42699
@jblueh
Enable address sanitizer execution of SU2_CFD_AD serial regression AD…
a65d31c 
… tests.
@jblueh
Enable asan execution of SU2_GEO and SU2_DEF serial regression tests.
3477fba
@jblueh
Fixes in run_geo and run_def.
38b6658
EvertBunschoten and others added 21 commits August 19, 2024 11:48
@EvertBunschoten
Merge branch 'develop' into feature_solid-solid_cht
ab011a0
@EvertBunschoten
Removed solid-to-solid CHT regression test from TestCases
07e1134
@EvertBunschoten
Updated tutorials and testcases branch
d560eb6
@EvertBunschoten
Removed boolean for the application of contact resistance
b3b31fb
@EvertBunschoten
Constant contact resistance is applied to all CHT interfaces if a sin…
64e29b8 
…gle value is provided
@EvertBunschoten
Removed duplicate code
c8db996
@EvertBunschoten
Removed check for the use of contact resistance
26d0776
@EvertBunschoten
Moved solid-solid CHT regression test from TestCases to Tutorials
ed6acbf
@EvertBunschoten
Updated tutorials branch
2dee186
@Cristopher-Morales
small fix (su2code#2345)
ab5cfb7
@EvertBunschoten
Merge branch 'develop' of https://github.com/su2code/SU2 into feature…
d0bd167 
…_solid-solid_cht
@EvertBunschoten
Pulled develop
a78dccb
@EvertBunschoten
Updated residual values
137ebf7
@EvertBunschoten
Updated SS-CHT tutorial regression test residual values
7fc46b6
@joshkellyjak
Modification of some comments
55d4d16
@EvertBunschoten
Updated residuals according to regression test output
b02c5f8
@EvertBunschoten
Merge pull request su2code#2152 from su2code/feature_solid-solid_cht
66ed495 
Solid to solid conjugate heat transfer with contact resistance
@joshkellyjak
Fixed MP bug added additional outputs
e1eba79
@joshkellyjak
Merge branch 'develop' into feature_turbo_interfaces
9324146
@joshkellyjak
Revert "Merge remote-tracking branch 'origin/feature_mz_adjoint_for_t…
05f9d23 
…urbo' into pr/2209"

This reverts commit 6b4c180, reversing
changes made to fd6d5cb.

This was a big mistake! I need to remerge develop after this.
@joshkellyjak
Changes for comments and reversion error fix
9db6939
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 4, 2024
View reviewed changes
SU2_CFD/include/solvers/CFVMFlowSolverBase.inl Outdated

/*--- Compute and update residual. Note that the viscous shear stress tensor is computed in the
following routine based upon the velocity-component gradients. ---*/
auto residual = visc_numerics->ComputeResidual(config);

Check notice

Code scanning / CodeQL

Declaration hides variable Note

Variable residual hides another variable of the same name (on
line 1224
Loading
).
SU2_CFD/src/numerics/flow/convection/hllc.cpp Outdated
@@ -161,8 +175,10 @@

/*--- Roe-averaged speed of sound ---*/

//RoeSoundSpeed2 = Gamma_Minus_One * ( RoeEnthalpy - 0.5 * sq_velRoe );

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
@joshkellyjak joshkellyjak changed the base branch from develop to feature_turbo_interfaces September 4, 2024 14:23
@joshkellyjak joshkellyjak merged commit d106401 into su2code:feature_resolve_merge_turbo_interfaces Sep 4, 2024
2 of 3 checks passed
@joshkellyjak joshkellyjak mentioned this pull request Sep 4, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jblueh jblueh jblueh left review comments

@pcarruscag pcarruscag pcarruscag left review comments

@EvertBunschoten EvertBunschoten EvertBunschoten approved these changes

Assignees

@joshkellyjak joshkellyjak

Labels
changelog:feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.