Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify and extend AD tape choices #2107

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Clarify and extend AD tape choices #2107

merged 3 commits into from
Aug 16, 2023

Conversation

jblueh
Copy link
Contributor

@jblueh jblueh commented Aug 14, 2023

Proposed Changes

JacobianIndex, one of the codi-tape build options, was prone to misunderstandings since it was not clear whether or not the underlying type supports copy optimizations. There are two options now, JacobianReuse, which does not support copy optimizations and is similar to the hybrid AD type in that regard, and JacobianMultiUse, which does support copy optimizations and is similar to the default type with linear management in that regard.

I took the opportunity to also add options for primal value tapes in a consistent manner, they were there previously but less detailed and commented out.

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@jblueh jblueh changed the title [WIP] Clarify and extend AD tape choices Clarify and extend AD tape choices Aug 15, 2023
@jblueh jblueh merged commit da0c951 into develop Aug 16, 2023
@jblueh jblueh deleted the codipack_tape_options branch August 16, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants