Clarify and extend AD tape choices #2107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
JacobianIndex
, one of thecodi-tape
build options, was prone to misunderstandings since it was not clear whether or not the underlying type supports copy optimizations. There are two options now,JacobianReuse
, which does not support copy optimizations and is similar to the hybrid AD type in that regard, andJacobianMultiUse
, which does support copy optimizations and is similar to the default type with linear management in that regard.I took the opportunity to also add options for primal value tapes in a consistent manner, they were there previously but less detailed and commented out.
PR Checklist